Hannes Eder wrote:
> Impact: Move variable declaration as close to their usage as possible.
>
> Fix this sparse warning:
> drivers/net/sfc/tenxpress.c:589:22: warning: symbol 'link_ok' shadows an earlier one
> drivers/net/sfc/tenxpress.c:575:30: originally declared here
>
> Signed-off-by: Hannes Eder <hannes@xxxxxxxxxxxxxx>
Acked-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
> ---
> drivers/net/sfc/tenxpress.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/sfc/tenxpress.c b/drivers/net/sfc/tenxpress.c
> index ac9eeab..5b0f451 100644
> --- a/drivers/net/sfc/tenxpress.c
> +++ b/drivers/net/sfc/tenxpress.c
> @@ -572,15 +572,14 @@ static void tenxpress_phy_reconfigure(struct efx_nic *efx)
> static void tenxpress_phy_poll(struct efx_nic *efx)
> {
> struct tenxpress_phy_data *phy_data = efx->phy_data;
> - bool change = false, link_ok;
> - unsigned link_fc;
> + bool change = false;
>
> if (efx->phy_type == PHY_TYPE_SFX7101) {
> - link_ok = sfx7101_link_ok(efx);
> + bool link_ok = sfx7101_link_ok(efx);
> if (link_ok != efx->link_up) {
> change = true;
> } else {
> - link_fc = mdio_clause45_get_pause(efx);
> + unsigned int link_fc = mdio_clause45_get_pause(efx);
> if (link_fc != efx->link_fc)
> change = true;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
