On Sun, Feb 15, 2009 at 12:24 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Sat, Feb 14, 2009 at 10:46:24PM +0100, Hannes Eder wrote: >> Impact: Use '__u16' instead of '__u8', this possibly fixes a bug. >> >> Fix this sparse warnings: >> drivers/net/tokenring/smctr.c:4410:52: warning: cast truncates bits from constant value (100 becomes 0) >> drivers/net/tokenring/smctr.c:4415:52: warning: cast truncates bits from constant value (400 becomes 0) >> drivers/net/tokenring/smctr.c:4420:52: warning: cast truncates bits from constant value (800 becomes 0) >> drivers/net/tokenring/smctr.c:4425:52: warning: cast truncates bits from constant value (1000 becomes 0) >> drivers/net/tokenring/smctr.c:4430:52: warning: cast truncates bits from constant value (2000 becomes 0) >> drivers/net/tokenring/smctr.c:4435:52: warning: cast truncates bits from constant value (4000 becomes 0) >> drivers/net/tokenring/smctr.c:4440:52: warning: cast truncates bits from constant value (8000 becomes 0) > > Um, no. Here's a better question: does *anything* use ->current_ring_status > at all? Answer: no. Next question: did anything use it in the past? > git log -p drivers/net/tokenging/smctr.c in historical trees shows that > it had always been defined that way and that it had never been used at > all. > > So how about removing the damn field completely? Or asking the driver's > author what the hell had it been about? > I vote for removing the field, I prepare a patch for this. Comments? -Hannes -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
