On Sat, Dec 27, 2008 at 08:11:11PM +0100, Hannes Eder wrote: > On 12/26/08, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote: > > On Thu, 25 Dec 2008 16:17:40 -0800 (PST) > > > > David Miller <davem@xxxxxxxxxxxxx> wrote: > > > > > > > From: Hannes Eder <hannes@xxxxxxxxxxxxxx> > > > Date: Mon, 22 Dec 2008 20:15:17 +0100 > > > > > > > Fix this sparse warning: > > > > > > > > drivers/net/niu.c:8850:2: warning: returning void-valued expression > > > > > > > > Signed-off-by: Hannes Eder <hannes@xxxxxxxxxxxxxx> > > > > > > Can we just fix sparse not to generate this warning? It's > > > marginal, at best. C++ even explicitly defines this as valid > > > and last time I brought this up Linus even agreed. > > > > > > Ack, I discussed it with him also and he thought that > > they were just fine as they were... > > > > > > > The types match, the function returns void and it is returning a void, > > > what is the problem? > > In fact there is no need to _fix_ sparse, as there is a command line option > -Wreturn-void / -Wno-return-void, so we could change the Makefile, see diff > below. It is default off but out use of "-Wall" turn it on. So your patch is the right approach. Can you please re-send it with a proper changelog and signed-off. Sam -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
