On Tue, 2008-12-23 at 17:31 +0100, Krzysztof Halasa wrote: > "Håkon Løvdal" <hlovdal@xxxxxxxxx> writes: > > > For this specific issue the important aspect is to improve readability > > (and not just eventually satisfy some warning from a tool), which I > > assume there is no disagrement on. > > Precisely. > > > Now what constitutes improved > > readbility on the other hand is another issue, and I guess there are > > next to as many oppinions as developers... :) > > Yes. Thus the brackets (or lack of them) of do-while loops should > never be forced as a part of coding standard/tools. This is just an > unimportant detail of personal style and trying to force it is simply > damaging to all of us. > > > Of secondary importance is the benefit that always using brackets > > makes them much more merge friendly. > > There are many ways to make the code more merge friendly at a cost of > readability. Hope we don't go this way. Linus himself added that particular warning to sparse...may want to check with him the reason for it. Harvey -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
