On Sat, Dec 20, 2008 at 1:11 AM, Julia Lawall <julia@xxxxxxx> wrote: > From: Julia Lawall <julia@xxxxxxx> > > If the NULL test is necessary, then the dereference should be moved below > the NULL test. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > type T; > expression E; > identifier i,fld; > statement S; > @@ > > - T i = E->fld; > + T i; > ... when != E > when != i > if (E == NULL) S > + i = E->fld; > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > drivers/staging/agnx/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -u -p a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c > --- a/drivers/staging/agnx/pci.c > +++ b/drivers/staging/agnx/pci.c > @@ -440,11 +440,12 @@ static struct ieee80211_ops agnx_ops = { > static void __devexit agnx_pci_remove(struct pci_dev *pdev) > { > struct ieee80211_hw *dev = pci_get_drvdata(pdev); > - struct agnx_priv *priv = dev->priv; > + struct agnx_priv *priv; > AGNX_TRACE; > > if (!dev) > return; > + priv = dev->priv; > ieee80211_unregister_hw(dev); > pci_iounmap(pdev, priv->ctl); > pci_iounmap(pdev, priv->data); > Thanks! Will pulled to the AGNX git tree. BR Yanbo -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
