Re: [PATCH] [XFS] fix sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
> 
> Fix the following sparse warning:
> 
>   fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
> 
> Signed-off-by: Hannes Eder <hannes@xxxxxxxxxxxxxx>
> ---
>  fs/xfs/xfs_inode.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
>  static inline void xfs_destroy_inode(struct xfs_inode *ip)
>  {
>  	make_bad_inode(VFS_I(ip));
> -	return destroy_inode(VFS_I(ip));
> +	destroy_inode(VFS_I(ip));
>  }

Yes, this makes sense.  Thanks for the patch.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux