On Thu, Oct 16, 2008 at 08:50:51PM -0700, Mike Steiner wrote: > - if (increment < -40) > - increment = -40; > - if (increment > 40) > - increment = 40; > + increment = CONSTRAIN_TO_RANGE(-40, increment, 40); I'm sorry, I just don't see this as a 'readability improvement'. I can tell exactly what the original does; the second one looks complex. Even writing it as: increment = max(min(increment, 40), -40) doesn't really improve it. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
