From: Julien Brunel <brunel@xxxxxxx> Date: Mon, 1 Sep 2008 10:53:33 +0200 > In case of error, the function xfrm_bundle_create returns an ERR > pointer, but never returns a NULL pointer. So a NULL test that comes > after an IS_ERR test should be deleted. > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @match_bad_null_test@ > expression x, E; > statement S1,S2; > @@ > x = xfrm_bundle_create(...) > ... when != x = E > * if (x != NULL) > S1 else S2 > // </smpl> > > Signed-off-by: Julien Brunel <brunel@xxxxxxx> > Signed-off-by: Julia Lawall <julia@xxxxxxx> Looks good, patch applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
