On Tue, 5 Aug 2008, Matthew Wilcox wrote:
> On Tue, Aug 05, 2008 at 10:27:03PM -0400, Robert P. J. Day wrote:
> > ok ... what is the point of the following?
> >
> > #ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE
> > fs_initcall(cpufreq_gov_userspace_init);
> > #else
> > module_init(cpufreq_gov_userspace_init);
> > #endif
> >
> > and why can't it be reduced?
>
> That's a silly author. The correct patch would look something like
> this:
>
> -#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE
> fs_initcall(cpufreq_gov_userspace_init);
> -#else
> -module_init(cpufreq_gov_userspace_init);
> -#endif
ah ... so after being condescending and snotty to me in your previous
posting here when i suggested that some cleanup could be done, you've
responded to my followup post and admitted that ... some cleanup could
be done.
you might have gone with that right off the bat and not come off as
such a total douchebag, matthew. it would have saved us all a bit of
time. know what i'm sayin'?
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
