On Wed, Jul 30, 2008 at 5:03 PM, Alexander Beregalov
<a.beregalov@xxxxxxxxx> wrote:
> From: Alexander Beregalov <a.beregalov@xxxxxxxxx>
>
> atyfb_base.c: fix warning
>
> drivers/video/aty/atyfb_base.c:2663: warning: 'aty_resume_chip' defined
> but not used
>
> Signed-off-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
> Cc: Ville Syrjala <syrjala@xxxxxx>
> Cc: Antonino A. Daplas <adaplas@xxxxxxx>
Looks good, should you maybe move the aty_resume_chip() up into the
existing #if defined(CONFIG_PM) &&... that atyfb_pci_resume() is in?
Not sure, just a thought.
Reviewed-by: Mark Asselstine <asselsm@xxxxxxxxx>
> ---
>
> drivers/video/aty/atyfb_base.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
> index 620ba81..9e5dfb1 100644
> --- a/drivers/video/aty/atyfb_base.c
> +++ b/drivers/video/aty/atyfb_base.c
> @@ -244,7 +244,9 @@ static int atyfb_sync(struct fb_info *info);
> */
>
> static int aty_init(struct fb_info *info);
> +#if defined(CONFIG_PM) && defined(CONFIG_PCI)
> static void aty_resume_chip(struct fb_info *info);
> +#endif
> #ifdef CONFIG_ATARI
> static int store_video_par(char *videopar, unsigned char m64_num);
> #endif
> @@ -2659,6 +2661,7 @@ aty_init_exit:
> return ret;
> }
>
> +#if defined(CONFIG_PM) && defined(CONFIG_PCI)
> static void aty_resume_chip(struct fb_info *info)
> {
> struct atyfb_par *par = info->par;
> @@ -2671,6 +2674,7 @@ static void aty_resume_chip(struct fb_info *info)
> if (par->aux_start)
> aty_st_le32(BUS_CNTL, aty_ld_le32(BUS_CNTL, par) | BUS_APER_REG_DIS, par);
> }
> +#endif /* defined(CONFIG_PM) && defined(CONFIG_PCI) */
>
> #ifdef CONFIG_ATARI
> static int __devinit store_video_par(char *video_str, unsigned char m64_num)
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
