On Monday 21 July 2008 09:57, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > The mutex is released on a successful return, so it would seem that it > should be released on an error return as well. > > The semantic patch finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > expression l; > @@ > > mutex_lock(l); > ... when != mutex_unlock(l) > when any > when strict > ( > if (...) { ... when != mutex_unlock(l) > + mutex_unlock(l); > return ...; > } > | > mutex_unlock(l); > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > diff -u -p a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > --- a/drivers/net/ehea/ehea_main.c > +++ b/drivers/net/ehea/ehea_main.c > @@ -2937,9 +2937,9 @@ static void ehea_rereg_mrs(struct work_s > } > } > } > - mutex_unlock(&dlpar_mem_lock); > - ehea_info("re-initializing driver complete"); > + ehea_info("re-initializing driver complete"); > out: > + mutex_unlock(&dlpar_mem_lock); > return; > } > > -- The patch looks good. Acked-by: Jan-Bernd Themann <themann@xxxxxxxxxx> Thanks, Jan-Bernd > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
