On Sat, 2008-07-26 at 01:08 +0800, rae l wrote: > On Sat, Jul 26, 2008 at 12:42 AM, Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > On Fri, Jul 25, 2008 at 10:48:33AM +0800, Denis ChengRq wrote: > >> Signed-off-by: Denis ChengRq <crquan@xxxxxxxxx> > > > > No justification or changelog? > I think no more explanation needed, the subject is definite. > > and no justification happened here, (there are justifications otherwhere) > > >> - __FUNCTION__) > >> + __func__) > > > > include/linux/kernel.h:503:#define __FUNCTION__ (__func__) > This solution is not completely, > > > > > I assume you're trying to kill this? > Eventually we will need a replace in the whole tree: > > grep -RsInw __FUNCTION__ . |xargs sed -i -e 's/__FUNCTION__/__func__/g' Actually, we already have such a maintained patch by Harvey Harrison, so we don't really need another. Since nearly every other subsystem has done this, I was thinking we could do it around -rc1 which should cause the minimal disruption. James -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
