On Thu, 24 Jul 2008, walter harms wrote: > local_irq_save(saved_psr); > slot = ia64_itr_entry(0x3, KVM_VMM_BASE, pte, KVM_VMM_SHIFT); > local_irq_restore(saved_psr); > > maybe it is posible to move that local_irq_save() into ia64_itr_entry() directly ? How would one make that decision? At the moment, the function is only called in four places, all in the same file (arch/ia64/kvm/kvm-ia64.c). In two places, the code has the above pattern. In the other two, the turning off of interrupts is around several levels of enclosing fuction calls. In the defining file (arch/ia64/mm/tlb.c), there is also the function ia64_ptr_entry. One seems to allocate and the other deallocates. Both have the comment "Must be called with preemption disabled." So perhaps if one is changed, the other should be changed as well? julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
