On Mon, 21 Jul 2008 09:58:55 +0200 (CEST) Julia Lawall <julia@xxxxxxx> wrote: > From: Julia Lawall <julia@xxxxxxx> > > The mutex is released on a successful return, so it would seem that it > should be released on an error return as well. > > The semantic patch finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > expression l; > @@ > > mutex_lock(l); > ... when != mutex_unlock(l) > when any > when strict > ( > if (...) { ... when != mutex_unlock(l) > + mutex_unlock(l); > return ...; > } > | > mutex_unlock(l); > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- Acked-by: Krzysztof Helt <krzysztof.h1@xxxxx> ---------------------------------------------------------------------- Partyjka w Chinczyka? Graj >>> http://link.interia.pl/f1e67 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
