Hi Julia, On Mon, 9 Jun 2008 15:22:53 +0200 (CEST) Julia Lawall <julia@xxxxxxx> wrote: > > > However, the error handling in that routine (smu_init) needs much more > > work. > > Indeed, the smu = NULL at the end of the function seems a bit brutal - a > lot of allocated data ends up not getting freed. I can try to do > something about it. Did you see something else? There are paths to fail: where you would need to of_node_put smu->db_node or smu->msg_node (or both) and undo the smu->db_buf ioremap. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpP2TvopfSPk.pgp
Description: PGP signature
