On Wed, 23 Apr 2008, Roel Kluin wrote: > Julia Lawall wrote: > > >> and besides your evaluated the tests: > >> > >> * i < [any negative value] > >> * i >= [0 or any negative value] > >> * i == [any negative value] > >> * i != [any negative value] > >> * [0 or any negative value] <= i > >> * [0 or any negative value] > i > > > > We do 0 > i via the isomoprhisms. But I have never seen such code. > > > > As you mention, we could consider more kinds of comparison to 0 by writing > > more patterns, eg; > > > > ( > > i < 0 > > | > > i <= 0 > > | > > i == -C > > | > > i < -C > > | > > i <= -C > > ) > > > > where C was previously declared to be any constant. > > this should be different: > > ( > * i < 0 > | > * i == -C > | > * i < -C > | > * i >= -C > ) Agreed. But maybe i <= -C should be there too? And i > -C. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
