On Sat, 19 Apr 2008, Matthew Wilcox wrote: > On Fri, Apr 18, 2008 at 09:08:55PM +0200, Julia Lawall wrote: > > I found 63 occurrences of this problem with the following semantic match > > (http://www.emn.fr/x-info/coccinelle/): > > > > @@ unsigned int i; @@ > > > > * i < 0 > > Could you also look for unsigned long? A few more... julia ------------------------------ diff -u -p a/drivers/video/amifb.c b/drivers/video/amifb.c *** a/drivers/video/amifb.c 2008-03-12 14:13:14.000000000 +0100 @@ -2053,7 +2053,7 @@ static void amifb_copyarea(struct fb_inf sy = area->sy + (dy - area->dy); /* the source must be completely inside the virtual screen */ * if (sx < 0 || sy < 0 || (sx + width) > info->var.xres_virtual || (sy + height) > info->var.yres_virtual) return; diff -u -p a/drivers/video/atafb.c b/drivers/video/atafb.c *** a/drivers/video/atafb.c 2008-03-12 14:13:14.000000000 +0100 @@ -2598,7 +2598,7 @@ static void atafb_copyarea(struct fb_inf sy = area->sy + (dy - area->dy); /* the source must be completely inside the virtual screen */ * if (sx < 0 || sy < 0 || (sx + width) > info->var.xres_virtual || (sy + height) > info->var.yres_virtual) return; diff -u -p a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c *** a/drivers/video/aty/aty128fb.c 2008-03-12 14:13:14.000000000 +0100 @@ -1350,7 +1350,7 @@ static int aty128_var_to_pll(u32 period_ } } * if (pll->post_divider < 0) return -EINVAL; /* calculate feedback divider */ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html