Re: trying to avoid "#ifdef CONFIG_NUMA"?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 07, 2008 at 07:45:01AM -0400, Robert P. J. Day wrote:
> /* This helps us to avoid #ifdef CONFIG_NUMA */
> #ifdef CONFIG_NUMA
> #define NUMA_BUILD 1
> #else
> #define NUMA_BUILD 0
> #endif

> mm/page_alloc.c:                if (NUMA_BUILD && zlc_active &&
> 
>   not a lot of avoiding going on there, i'd say.

but it's important where it happens.  it would uglify the code
significantly to replace the if (NUMA_BUILD) with #ifdef CONFIG_NUMA.
Maybe NUMA_BUILD should be used in more places, but how about doing
something useful instead?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux