> On Wed, Jan 09, 2008 at 03:37:50AM +0000, Dave Airlie wrote: > > > > > The drm drivers in this patch all used drm_ioctl to perform their > > > ioctl calls. The common function is converted to use lock_kernel() > > > and unlock_kernel() and the drivers are converted to use .unlocked_ioctl > > > > > > > NAK > > Did you actually read Kevin's patch? Kevin's patch adds the lock/unlock to drm_ioctl which is exactly what I don't want, I want to have drm_ioctl become drm_unlocked_ioctl, and drm_ioctl to wrap it with the lock/unlocks, then the drivers can all use unlocked_ioctl like Kevins patch pointing to drm_ioctl, and can migrate over to drm_unlocked_ioctl post lock auditing, the new latest i915 driver seems to be fine with unlocked ioctls so far.. Yes I can use Kevin's patch as a base most likely, but it doesn't do what I want yet, and I've already started to do it properly in the drm upstream trees.... Dave. - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html