On Mon, Dec 31, 2007 at 09:17:32AM +0000, Christoph Hellwig wrote: > > be32_add is shorter than be32_add_cpu but I think it's not clear > > whether second parameter is in native byte order or not. > > Then again adding foreing endian values doesn't make much sense. > > If you insist on your naming please make sure to convert ocfs and xfs > to your naming. Personally, I'd rather stick with the (IMHO) more descriptive name - btw, the ones he picked don't require any extra conversion in Ocfs2. --Mark -- Mark Fasheh Principal Software Developer, Oracle mark.fasheh@xxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html