From: Julia Lawall <julia@xxxxxxx> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @ change_compare_np @ expression E; @@ ( - jiffies <= E + time_before_eq(jiffies,E) | - jiffies >= E + time_after_eq(jiffies,E) | - jiffies < E + time_before(jiffies,E) | - jiffies > E + time_after(jiffies,E) ) @ include depends on change_compare_np @ @@ #include <linux/jiffies.h> @ no_include depends on !include && change_compare_np @ @@ #include <linux/...> + #include <linux/jiffies.h> // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- diff -r -u -p a/net/econet/af_econet.c b/net/econet/af_econet.c --- a/net/econet/af_econet.c 2007-11-08 08:00:53.000000000 +0100 +++ b/net/econet/af_econet.c 2007-12-23 20:30:40.000000000 +0100 @@ -41,6 +41,7 @@ #include <linux/rcupdate.h> #include <linux/bitops.h> #include <linux/mutex.h> +#include <linux/jiffies.h> #include <asm/uaccess.h> #include <asm/system.h> @@ -993,7 +994,7 @@ static void ab_cleanup(unsigned long h) { struct sk_buff *newskb = skb->next; struct ec_cb *eb = (struct ec_cb *)&skb->cb; - if ((jiffies - eb->start) > eb->timeout) + if (time_after(jiffies, eb->start + eb->timeout)) { tx_result(skb->sk, eb->cookie, ECTYPE_TRANSMIT_NOT_PRESENT); - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
