Julia Lawall said the following on 2007-12-10 15:18: >> Julia, seems that your semantic patch misses following place. >> >> drivers/s390/net/qeth_main.c:2733 >> ... >> #endif >> rxrc = netif_rx(skb); >> card->dev->last_rx = jiffies; >> card->stats.rx_packets++; >> card->stats.rx_bytes += skb->len; >> ... > > Actually, I found this one as well, but I wasn't sure what to do with it. > This one is a bit more complicated because the line with the call to > netif_rx is in an else branch if the #ifdef above is taken. So I wasn't > sure what would be the best way to solve the problem in this case. > > Perhaps the solution would be just to save the value of the len field > in a local variable in this case, as you proposed in your original patch. > I agree. BTW, please send driver patch to Jeff Garzik <jgarzik@xxxxxxxxx> and cc to netdev@xxxxxxxxxxxxxxxx -- WCN - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
