On Mon, Dec 03, 2007 at 01:20:20AM +0100, Roel Kluin wrote: > for instance in a patch I saw this: > > > + if (__blk_end_request(rq, 0, 0)) > > + BUG(); > > spin_unlock(q->queue_lock); > > If it's still bad, what should the fix be? (I'll write a script and post > patches) This one should not be converted to a BUG_ON. We always want to call __blk_end_request(), whether we have CONFIG_BUG or not. This case just wants to test the return value. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
