On Mon, 2007-11-19 at 09:03 +0100, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > There should be a pci_dev_put when breaking out of a loop that iterates > over calls to pci_get_device and similar functions. > > In this case, the return under the #else case of #ifdef HACKED_PCI_SAVE > should have a pci_dev_put, just as the return in the case where > HACKED_PCI_SAVE is true does. > > This was fixed using the following semantic patch. I think most of that code is no longer necessary (and the lack of pci_dev_put() is mostly due to the fact that this code long predates the existence of pci_dev_put :-) I want to try out without that PCI save/restore code on a couple of old machines see if we can just remove the whole thing. Ben. - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
