On Wed, 14 Nov 2007 12:54:52 -0800 Roland Dreier wrote: > > Drop #include <linux/moduleparam.h> in files that also include #include > > <linux/module.h>. module.h includes moduleparam.h already. > > Do we want to make this sort of source code change? I thought that > the consensus about the kernel was that we wanted to avoid relying of > implicit includes of <Y.h> by <X.h> -- in this case a better change > would actually seem to be to explicitly include moduleparam.h in files > using module parameters and then remove the include from module.h. That's correct AFAIK (what Roland said). --- ~Randy - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html