On Fri, 7 Sep 2007 17:16:56 +0200 Andre Haupt wrote: > On Fri, Sep 07, 2007 at 08:13:37AM -0700, Randy Dunlap wrote: > > On Fri, 7 Sep 2007 18:54:45 +0400 Alexey Dobriyan wrote: > > > > > On 9/7/07, Andre Haupt <andre@xxxxxxxxxx> wrote: > > > > I have a driver (drivers/atm/iphase.*) which i try to get in conformance > > > > with CodingStyle. I started by fixing whitespace issues (by hand). The > > > > resulting > > > > patch is about 177 kB because those whitespace issues appear on every > > > > single line of the original file. > > > > Is it ok to send this large patch to kernel-janitors and lkml? > > > > > > > > BTW, this driver has *LOTS* of additional style problems. All kinds of > > > > mixed indentation to name one. > > > > > > Send "Linus please do Lindent blah-blah" request to Linus. Before that > > > do it yourself and verify that code doesn't change or something. > > > > or do whitespace-only changes and verify that the code does not change > > any, and put that comment in the patch description. > > > That is what i did ;-) > So it is ok to send the patch? I think so, but the question IMO is where to send it. I would send it to the ATM maintainer and cc: Dave Miller and the netdev mailing list, but using lkml is OK also. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
