Re: [PATCH] Add macro to round down to nearest power of two.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 5 Sep 2007, vignesh babu wrote:

> Resending this...as I did not get the mail thru KJ...
>
> Robert,
>
>  Maybe its late, but I would still like to discuss if it is
> needed-is_power_of_2 has '2' and not 'two' which I think is easier to
> work with. I was hoping that the 2 macros that you have coded can also
> be named with a '2' in them than a 'two'.
>
> There have been many changes that went in already based on these 2
> macros.I have the cleanup patches ready(for log2.h AND all the changes
> that went in), but my net at home went down, should be up in a few
> hours and so i should be able to mail in the cleanups in a few hours.
>
> If you and others feel that the 'two's can be replaced with '2' then I
> would push in the patches by tonight.

sorry for the delay in answering this -- i suspect we're stuck with
"two" since that's what the existing roundup macro used.  does anyone
else have a strong opinion on this either way?  personally, i would
have preferred "2", but it might be too late for that.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux