On Fri, 24 Aug 2007 15:15:30 -0400 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: >ase, 0x80); >> >> remove also the hwbase var. >> >> > + rebase = pci_iomap(pdev, 0, 0x80); >> > t = readl(rebase + CNTRL_REG_OFFSET); > >Switch to ioread* if you are using the iomap interface. Its not a >trivial >conversion and its slower and bulkier - the original ioremap was >much >better > >NAK this change therefore Jiri had requested this in relation to previous patch on unchecked ioremap return codes, but if the original ioremap is better NAK is fine here and I won't resubmit w/ the hwbase var pulled out or the readl -> ioread32 switchover. --------------------------------------- Scott Thompson / postfail@xxxxxxxxxxxx --------------------------------------- - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
