On Sat, Mar 22, 2025 at 02:24:30PM -0400, Tamir Duberstein wrote: > On Sat, Mar 22, 2025 at 11:08 AM Antonio Hickey > <contact@xxxxxxxxxxxxxxxxx> wrote: > > > > On Sat, Mar 22, 2025 at 10:16:01AM +0000, Benno Lossin wrote: > > > On Thu Mar 20, 2025 at 3:07 AM CET, Antonio Hickey wrote: > > > > Since Rust 1.82.0 the `raw_ref_op` feature is stable. > > > > > > > > By enabling this feature we can use `&raw const place` and > > > > `&raw mut place` instead of using `addr_of!(place)` and > > > > `addr_of_mut!(place)` macros. > > > > > > > > Allowing us to reduce macro complexity, and improve consistency > > > > with existing reference syntax as `&raw const`, `&raw mut` are > > > > similar to `&`, `&mut` making it fit more naturally with other > > > > existing code. > > > > > > > > Suggested-by: Benno Lossin <benno.lossin@xxxxxxxxx> > > > > Link: https://github.com/Rust-for-Linux/linux/issues/1148 > > > > Signed-off-by: Antonio Hickey <contact@xxxxxxxxxxxxxxxxx> > > > > > > Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx> > > > > > > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > > > > index 993708d11874..a73aaa028e34 100644 > > > > --- a/scripts/Makefile.build > > > > +++ b/scripts/Makefile.build > > > > @@ -224,9 +224,9 @@ $(obj)/%.lst: $(obj)/%.c FORCE > > > > $(call if_changed_dep,cc_lst_c) > > > > > > > > # Compile Rust sources (.rs) > > > > -# --------------------------------------------------------------------------- > > > > +# -------------------------------------------------------------------------------------- > > > > > > Not sure about this change. > > > > This change is so I could enable the `raw_ref_op` feature for doctests > > since the minimum Rust version 1.78 still has `raw_ref_op` as an > > expiramental feature, and will throw errors at compile if a doctest uses > > it. Is there a better way to do this? > > I think Benno is just asking about the extension of the dashed line. Ahh ok yea that makes sense, thanks Tamir, sorry Benno I misunderstood. So the reason I extended the dashed line was because before my change the dashed line perfectly aligned with number of characters in the line I changed. I figured it was supposed to match the amount of characters of the line. Giving this a deeper look it looks like the all the other dashed lines are maxed at 77 characters. I will update this. Thanks, Antonio > > > > > > > > > -rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons > > > > +rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons,raw_ref_op > > This looks correct to me. > > > > > > > > > # `--out-dir` is required to avoid temporaries being created by `rustc` in the > > > > # current working directory, which may be not accessible in the out-of-tree > > > > > > > > Reviewed-by: Tamir Duberstein <tamird@xxxxxxxxx>
