On Tue, Mar 11, 2025 at 11:19 AM Xin Li <xin@xxxxxxxxx> wrote: > > On 3/10/2025 6:52 PM, Masahiro Yamada wrote: > > On Mon, Mar 10, 2025 at 3:23 PM Xin Li <xin@xxxxxxxxx> wrote: > >> > >> On 3/8/2025 7:12 AM, Masahiro Yamada wrote: > >>> On Sat, Mar 8, 2025 at 1:05 PM Xin Li (Intel) <xin@xxxxxxxxx> wrote: > >>>> > >>>> Meanwhile explicitly state that the headers are uapi headers. > >>> > >>> There are many internal-use targets, which are not documented in the > >>> help message. > >>> I assume this one is the case. > >>> > >>> If users want to install UAPI headers, 'headers_install' is > >>> the user-visible interface and it is already documented. > >>> > >>> > >> > >> hpa and Boris prefer to add it, which I also agree. But ofc it's your > >> call :) > >> > >> If you don't want to add help for "headers", it probably still makes > >> sense to explicitly state that the headers are uapi headers, no? > >> > >> Thanks! > >> Xin > > > > > > If a help message for "headers" is desired, how about this? > > > > headers - Build read-to-install uapi headers in usr/include > > > > LGTM. > > I guess you will make the change right now? > I will not do it myself, but I just suggested a change for v2. -- Best Regards Masahiro Yamada