On Wed, Dec 18, 2024 at 02:58:56PM +0000, Brendan Jackman wrote: > NOINSTR_VALIDATION is pretty helpful for detecting bugs, it would be > helpful for the build to fail when those bugs arise. > > If necessary it would be possible to enable this for individual > warnings, it seems unlikely there's a use-case for that though. So > for now just add a global setting. > > Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx> The patch looks good to me, though the subject and commit log still need to be updated. It's no longer specific to vmlinux or NOINSTR_VALIDATION. And the justification is similar to what I mentioned before: objtool warnings (even seemingly "harmless" ones) often indicate serious bugs which can break the kernel. -- Josh
