On Fri, Oct 4, 2024 at 3:47 AM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> On Tue, Sep 17, 2024 at 11:16:46PM +0900, Masahiro Yamada wrote:
> > With the previous changes, $(extmod_prefix), $(MODORDER), and
> > $(MODULES_NSDEPS) are constant. (empty, modules.order, and
> > modules.nsdeps, respectively).
> >
> > Remove these variables and hard-code their values.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> >
> > Makefile | 22 +++++++++-------------
> > scripts/Makefile.modfinal | 2 +-
> > scripts/Makefile.modinst | 2 +-
> > scripts/Makefile.modpost | 6 +++---
> > scripts/nsdeps | 2 +-
> > 5 files changed, 15 insertions(+), 19 deletions(-)
>
> Do you want to remove these also? I can't think of a reason to keep these
> around:
>
> $ git grep -Hrnwe extmod_prefix -e MODORDER -e MODULES_NSDEP
> Makefile:1912: $(Q){ $(foreach m, $(single-ko), echo $(extmod_prefix)$(m:%.ko=%.o);) } > modules.order
> scripts/Makefile.modfinal:33:$(extmod_prefix).module-common.o: $(srctree)/scripts/module-common.c FORCE
> scripts/Makefile.modfinal:60:%.ko: %.o %.mod.o $(extmod_prefix).module-common.o $(objtree)/scripts/module.lds $(and $(CONFIG_DEBUG_INFO_BTF_MODULES),$(KBUILD_BUILTIN),$(objtree)/vmlinux) FORCE
> scripts/Makefile.modfinal:66:targets += $(modules:%.o=%.ko) $(modules:%.o=%.mod.o) $(extmod_prefix).module-common.o
> scripts/Makefile.modinst:60:modules := $(patsubst $(extmod_prefix)%.o, $(dst)/%.ko$(suffix-y), $(modules))
> scripts/Makefile.modinst:120:$(dst)/%.ko: $(extmod_prefix)%.ko FORCE
Right, I will clean up these.
> W/ or w/o:
>
> Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>
--
Best Regards
Masahiro Yamada
