On 2024-11-02 13:05:26+0100, Peter Jung wrote:
> If the config is using DEBUG_INFO_BTF, it is required to,
> package resolve_btfids with.
This sentence sounds weird.
> Compiling dkms modules will fail otherwise.
Maybe we should add it to scripts/package/install-extmod-build so it
also works for all the other package types?
> Add a check, if resolve_btfids is present and then package it, if required.
>
> Signed-off-by: Peter Jung <admin@xxxxxxxxxxx>
> ---
> scripts/package/PKGBUILD | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index f83493838cf9..4010899652b8 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -91,6 +91,11 @@ _package-headers() {
> "${srctree}/scripts/package/install-extmod-build" "${builddir}"
> fi
>
> + # required when DEBUG_INFO_BTF_MODULES is enabled
> + if [ -f tools/bpf/resolve_btfids/resolve_btfids ]; then
I would prefer to actually test for DEBUG_INFO_BTF_MODULES instead of
file existence. This file may be stale when the option got disabled.
> + install -Dt "$builddir/tools/bpf/resolve_btfids" tools/bpf/resolve_btfids/resolve_btfids
> + fi
> +
> echo "Installing System.map and config..."
> mkdir -p "${builddir}"
> cp System.map "${builddir}/System.map"
> --
> 2.47.0
>
