On Wed, Oct 16, 2024 at 12:53 AM Tamir Duberstein <tamird@xxxxxxxxx> wrote: > > On Tue, Oct 15, 2024 at 11:30 AM Miguel Ojeda > <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > > > If a trick still requires a similar amount of changes to mainline, > > then I think we should go for something better/more proper, i.e. the > > idea is to minimize changes/complexity upstream, after all. > > In that case v5[0] is probably the way to go? > > On Mon, Oct 14, 2024 at 2:45 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > This no-clean-files is meaningless and unnecessary. > > This line exists inside the "ifdef CONFIG_RUST" ... "endif" block. > > > > no-clean-files is only used by scripts/Makefile.clean, > > which does not include include/config/auto.conf. > > I see. Was it necessary before this patch? Looks like it came with the > initial rust support patch. You can just delete no-clean-files from your patch. Files specified to $(always-y) are removed by "make clean". That's why [0] added no-clean-files to negate it. You are moving "always-$(CONFIG_RUST) += libmacros.so" into the "ifdef CONFIG_RUST" ... "endif" block, which is not parsed by "make clean". > > [0] https://lore.kernel.org/all/20241010142833.98528-2-tamird@xxxxxxxxx/ -- Best Regards Masahiro Yamada
