On Fri, Oct 11, 2024 at 3:13 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > On Wed, Sep 25, 2024 at 11:38:28PM +0000, Matthew Maurer wrote: > > * modules.order has .o files when in a build dir, support this > > The commit log is not clear, is it that it's always had *.o files, and > you're adding them now, why? Why is the .ko search now removed? The script was broken when I found it, but it was a script that analyzed MODVERSIONS, so I tried to ensure it would still work with my changes. This necessitated rehabilitating it first. I did not touch `.modules.order` files, but they contained `.o` and so this script wouldn't run correctly. > > > * .mod.c source layout has changed, > > When, why did this change not happen at that time? It was changed for readability [1] back in 2019. I assume the change did not happen at that time because this script is rarely run. If we'd prefer to discard this patch and ignore the script instead (or remove it?), that's fine. [1]: https://lore.kernel.org/all/20190909113423.2289-2-yamada.masahiro@xxxxxxxxxxxxx/ > > > update regexes to match > > Why did this not break anything before ? Is this fixing something, or > is it prep work? > > > * Add a stage 3, to be more robust against additional .mod.c content > > Future .mod.c changes? The rest of this series adds additional `.mod.c` content to support the string names. This stage 3 is intended to prevent that from causing the script to choke. > > Luis
