On Fri, Oct 11, 2024 at 1:41 PM Gary Guo <gary@xxxxxxxxxxx> wrote:
>
> The invocation of rustc-version is being moved from init/Kconfig to
> scripts/Kconfig.include for consistency with cc-version.
Yeah, I am ambivalent. Dropping them would minimize changes and avoid
introducing something only used once, which would be nice too. Happy
either way.
> +if output=$("$@" --version --verbose 2>/dev/null | grep LLVM); then
Similarly, I wonder if we should use '^LLVM version: ' here or similar
to minimize the chances the "LLVM" string appears elsewhere in the
future (perhaps in a custom string a vendor adds, though I would
expect them to add it lowercase). We are relying on having a $3 when
splitting anyway.
Depending on what Masahiro prefers, I will take this one or the
one-invocation-only one.
Thanks Gary!
Cheers,
Miguel
