Re: [PATCH 1/7] linux-kbuild: fix: config option can be bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/23/24 22:55, Masahiro Yamada wrote:

I do not see an immediate benefit from this patch.



Boolean CONFIG options are skipped due to the following code:

if (defined($orig_configs{$config}) && $orig_configs{$config} ne "m") {
     next forloop;
}


So, I do not understand why this patch is necessary
until I see 7/7.


Thank you for the feedback. I have been working on the second version for all of the patches, and I will resend the series patch soon. In the meantime, I have a few things I need cleared up, so I will reply to each email where appropriate.

For this email, I was a bit unsure of what my takeaway should be from this message. Are you saying one of the following:

1) The patch should be resent, but resent after the patch that is currently 7/7
2) The patch should be combined with the patch that is currently 7/7
3) The patch message should be improved so that people can see the need for the patch

As of now, my version 2 will be made with option 1, the patch will be after the current 7/7. If you had something different in mind, let me know. I would be happy to change it as needed.

Thanks,
David Hunter




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux