Re: [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 4, 2024 at 4:54 PM Aaron Thompson <dev@xxxxxxxxxx> wrote:
>
> From: Aaron Thompson <dev@xxxxxxxxxx>
>
> The blank line causes execve() to fail:
>
>   # strace ./postinst
>   execve("./postinst", ...) = -1 ENOEXEC (Exec format error)
>   strace: exec: Exec format error
>   +++ exited with 1 +++
>
> However running the scripts via shell does work (at least with bash)
> because the shell attempts to execute the file as a shell script when
> execve() fails.
>
> Fixes: b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
> Signed-off-by: Aaron Thompson <dev@xxxxxxxxxx>
> ---

Applied to linux-kbuild.
Thanks.


>  scripts/package/builddeb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c1757db6aa8a..404587fc71fe 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -74,7 +74,6 @@ install_linux_image () {
>
>                 mkdir -p "${pdir}/DEBIAN"
>                 cat <<-EOF > "${pdir}/DEBIAN/${script}"
> -
>                 #!/bin/sh
>
>                 set -e
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> --
> 2.39.5
>
>


-- 
Best Regards
Masahiro Yamada





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux