On Tue, Oct 1, 2024 at 3:38 AM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Tue, Sep 17, 2024 at 4:17 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > The correct use of the -prune option can be seen in the 'make clean' > > rule. > > Yeah, this `-prune` should not have been like that -- sorry about that. > > The comment above this recipe should be updated. > > I am not sure I understand the part of the commit message about the > rust/test change. Do you mean that we should use `srctree` in case > there is a stale one in the source tree from a previous > non-completely-clean in-source-tree build? Correct. > I think the original > intention was to skip the objtree one if it were a subdir of srctree > (and that is why the use of absolute paths). OK, understood. If you insist on the current logic, I will keep it as-is, but I need to replace $(abs_objtree) with $(CURDIR) because $(abs_objtree) will be removed by this series. > Although I think we can simplify further by just removing the logic > about `rust/test`, since we don't generate `*.rs` files there anyway > at the moment. OK, then we can remove -prune entirely. -- Best Regards Masahiro Yamada
