Re: [PATCH 6/6] kconfig: cache expression values

[Masahiro Yamada <masahiroy@xxxxxxxxxx>]

On Sun, Sep 8, 2024 at 9:44 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> Cache expression values to avoid recalculating them repeatedly.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>


I noticed a bunch of "unmet direct dependencies" for xconfig.


I will fix as follows:




diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index 78738ef412de..16f92c4a775a 100644
--- a/scripts/kconfig/expr.c
+++ b/scripts/kconfig/expr.c
@@ -47,6 +47,7 @@ static struct expr *expr_lookup(enum expr_type type,
void *l, void *r)
        e->type = type;
        e->left._initdata = l;
        e->right._initdata = r;
+       e->val_is_valid = false;

        hash_add(expr_hashtable, &e->node, hash);






-- 
Best Regards
Masahiro Yamada