On Fri, Sep 6, 2024 at 11:54 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
>
> On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay
> <devnull+da.gomez.samsung.com@xxxxxxxxxx> wrote:
> >
> > From: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> >
> > This tool is only used in security/selinux/Makefile.
> >
> > There is no reason to keep it under scripts/.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> > scripts/remove-stale-files | 3 +++
> > scripts/selinux/Makefile | 2 +-
> > scripts/selinux/genheaders/.gitignore | 2 --
> > scripts/selinux/genheaders/Makefile | 3 ---
> > security/selinux/.gitignore | 1 +
> > security/selinux/Makefile | 7 +++++--
> > {scripts/selinux/genheaders => security/selinux}/genheaders.c | 0
> > 7 files changed, 10 insertions(+), 8 deletions(-)
>
> Did you read my comments on your previous posting of this patch? Here
> is a lore link in case you missed it or it was swallowed by your
> inbox:
>
> https://lore.kernel.org/selinux/3447459d08dd7ebb58972129cddf1c44@xxxxxxxxxxxxxx
>
> Unless there is an serious need for this relocation, and I don't see
> one explicitly documented either in this patchset or the previous, I
> don't want to see this patch go upstream.
I commented on the previous thread.
I will reword it as follows:
--------------->8--------------------
selinux: move genheaders to security/selinux/
This tool is only used in security/selinux/Makefile.
Move it to security/selinux/ so that 'make clean' can clean it up.
Please note 'make clean' does not visit scripts/ because tools under
scripts/ are often used for external module builds. Obviously, genheaders
is not the case here.
--------------->8--------------------
--
Best Regards
Masahiro Yamada
