On Thu, Aug 29, 2024 at 10:51 PM Tony Battersby <tonyb@xxxxxxxxxxxxxxx> wrote:
>
> Remove the recently-added dependency on the truncate program for
> building the kernel. truncate is not available when building the kernel
> under Yocto. It could be added, but it would be better just to avoid
> the unnecessary dependency.
>
> Fixes: 1472464c6248 ("kbuild: avoid scripts/kallsyms parsing /dev/null")
> Signed-off-by: Tony Battersby <tonyb@xxxxxxxxxxxxxxx>
I have no objection.
'true' is a shell-builtin command, so it saves a process fork.
Applied to linux-kbuild. Thanks!
BTW, 'truncate' is used in drivers/firmware/efi/libstub/Makefile.zboot
(CONFIG_EFI_ZBOOT).
It seems to be no problem in Yocto.
> ---
> scripts/link-vmlinux.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 070a319140e8..c27b4e969f20 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -215,7 +215,7 @@ kallsymso=
> strip_debug=
>
> if is_enabled CONFIG_KALLSYMS; then
> - truncate -s0 .tmp_vmlinux.kallsyms0.syms
> + true > .tmp_vmlinux.kallsyms0.syms
> kallsyms .tmp_vmlinux.kallsyms0.syms .tmp_vmlinux0.kallsyms
> fi
>
>
> base-commit: 3e9bff3bbe1355805de919f688bef4baefbfd436
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
