Hi Masahiro,
On Thu, Aug 29, 2024 at 02:45:03AM +0900, Masahiro Yamada wrote:
> On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
> > +static int usage(void)
> > +{
> > + error("usage: gendwarfksyms [options] elf-object-file ...");
>
>
>
> Description for each option, please.
Sure, will add.
> > +static int parse_options(int argc, const char **argv)
>
>
>
> Why not getopt_long()?
Good point, I'll switch to getopt.
> > +int main(int argc, const char **argv)
> > +{
> > + unsigned int n;
> > +
> > + if (parse_options(argc, argv) < 0)
> > + return usage();
> > +
> > + for (n = 0; n < object_count; n++) {
>
>
> When does "object_count >= 2" happen ?
Right now it doesn't, but if we want to support LTO, we'll need to also
process the temporary object files we build for stand-alone assembly to
find types for the symbols exported there.
> > +extern int process_module(Dwfl_Module *mod, Dwarf *dbg, Dwarf_Die *cudie);
>
>
> No 'extern' for function declarations.
Ack, I'll drop these. Thanks for the review!
Sami
