On 24/08/18 09:35PM, Masahiro Yamada wrote: > On Sun, Aug 18, 2024 at 12:12 AM Jose Fernandez > <jose.fernandez@xxxxxxxxx> wrote: > > > > Add a new debug package to the PKGBUILD for the pacman-pkg target. The > > debug package includes the non-stripped vmlinux file, providing access > > to debug symbols needed for kernel debugging and profiling. The vmlinux > > file will be installed to /usr/src/debug/${pkgbase}. The debug package > > will be built by default and can be excluded by overriding PACMAN_EXTRAPACKAGES. > > > > Signed-off-by: Jose Fernandez <jose.fernandez@xxxxxxxxx> > > Reviewed-by: Peter Jung <ptr1337@xxxxxxxxxxx> > > --- > > v1->v2: > > - Use the new PACMAN_EXTRAPACKAGES [1] variable to allow users to disable the > > debug package if desired, instead of always including it. > > > > [1] https://lore.kernel.org/lkml/20240813185900.GA140556@thelio-3990X/T/ > > > > scripts/package/PKGBUILD | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD > > index fbd7eb10a52c..d40d282353de 100644 > > --- a/scripts/package/PKGBUILD > > +++ b/scripts/package/PKGBUILD > > @@ -5,7 +5,7 @@ > > pkgbase=${PACMAN_PKGBASE:-linux-upstream} > > pkgname=("${pkgbase}") > > > > -_extrapackages=${PACMAN_EXTRAPACKAGES-headers api-headers} > > +_extrapackages=${PACMAN_EXTRAPACKAGES-headers api-headers debug} > > for pkg in $_extrapackages; do > > pkgname+=("${pkgbase}-${pkg}") > > done > > @@ -106,6 +106,15 @@ _package-api-headers() { > > ${MAKE} headers_install INSTALL_HDR_PATH="${pkgdir}/usr" > > } > > > > +_package-debug(){ > > + pkgdesc="Non-stripped vmlinux file for the ${pkgdesc} kernel" > > + depends=(${pkgbase}-headers) > > > Why is this dependency necessary? > Hi Masahiro, My thinking was that you may need System.map in combination with vmlinux for debugging with tools like crash. I don't have a strong opinions on this, so I'm I can remove it if you or others think it's not necessary. > > + > > + cd "${objtree}" > > + mkdir -p "$pkgdir/usr/src/debug/${pkgbase}" > > + install -Dt "$pkgdir/usr/src/debug/${pkgbase}" -m644 vmlinux > > +} > > + > > for _p in "${pkgname[@]}"; do > > eval "package_$_p() { > > $(declare -f "_package${_p#$pkgbase}") > > > > base-commit: 869679673d3bbaaf1c2a43dba53930f5241e1d30 > > -- > > 2.46.0 > > > > > > > -- > Best Regards > Masahiro Yamada