On 8/12/24 10:46, Masahiro Yamada wrote: > On Wed, Jul 10, 2024 at 3:54 PM Ole Schuerks <ole0811sch@xxxxxxxxx> wrote: >> >> To translate the Kconfig-model into propositional logic and resolve >> conflicts, we need to handle propostional formulas. >> These files contain many functions and macros to deal with >> propositional formulas. >> >> Co-developed-by: Patrick Franz <deltaone@xxxxxxxxxx> >> Signed-off-by: Patrick Franz <deltaone@xxxxxxxxxx> >> Co-developed-by: Ibrahim Fayaz <phayax@xxxxxxxxx> >> Signed-off-by: Ibrahim Fayaz <phayax@xxxxxxxxx> >> Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> >> Tested-by: Evgeny Groshev <eugene.groshev@xxxxxxxxx> >> Suggested-by: Sarah Nadi <nadi@xxxxxxxxxxx> >> Suggested-by: Thorsten Berger <thorsten.berger@xxxxxx> >> Signed-off-by: Thorsten Berger <thorsten.berger@xxxxxx> >> Signed-off-by: Ole Schuerks <ole0811sch@xxxxxxxxx> >> --- >> scripts/kconfig/cf_expr.c | 2594 +++++++++++++++++++++++++++++++++++++ >> scripts/kconfig/cf_expr.h | 296 +++++ >> 2 files changed, 2890 insertions(+) >> create mode 100644 scripts/kconfig/cf_expr.c >> create mode 100644 scripts/kconfig/cf_expr.h >> +/* >> + * convert a fexpr to a pexpr >> + */ >> +struct pexpr *pexf(struct fexpr *fe) > > > > > Not only this one, but more descriptive function name please. > > "pexf", so what? > I do not understand what it is doing from the name. > > Could you give us one or two examples of what other functions have bad names? I didn't find anything as bad as pexf() so I'm not sure what the expectations are. Thank you, that would be helpful.
