Re: [PATCH] tools build: Provide consistent build options for fixdep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.08.24 19:53, Alexander Gordeev wrote:
> On Wed, Aug 14, 2024 at 10:35:00AM -0700, Brian Norris wrote:
>
>> FWIW, I already fielded some reports about this, and proposed a very
>> similar (but not identical) fix:
>>
>> https://lore.kernel.org/lkml/20240814030436.2022155-1-briannorris@xxxxxxxxxxxx/
>>
>> Frankly, I wasn't sure about HOSTxxFLAGS vs KBUILD_HOSTxxFLAGS -- and
>> that's the difference between yours and mine. If yours works, that
>> looks like the cleaner solution. So:
>>
>> Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
>>
>> Either way, it might be good to also include some of these tags if
>> this is committed:
>>
>> Closes: https://lore.kernel.org/lkml/99ae0d34-ed76-4ca0-a9fd-c337da33c9f9@xxxxxxxxxxxxx/
>> Fixes: ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues")
> 
> Ah, I missed the issue was reported already - I would include these tags otherwise.
> 
> @Thorsten, would it be possible to test this fix?

Yeah, np. This one works as well, so feel free to add:

Tested-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>

Ciao, Thorsten




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux