On 2024-08-09 18:16:36+0000, Jose Fernandez wrote:
> On 24/08/07 07:31PM, Thomas Weißschuh wrote:
> > On 2024-08-08 02:02:59+0000, Masahiro Yamada wrote:
> > > On Thu, Aug 8, 2024 at 1:41 AM Thomas Weißschuh <linux@xxxxxxxxxxxxxx> wrote:
> > > > On 2024-08-07 22:37:47+0000, Masahiro Yamada wrote:
> > > > > On Wed, Aug 7, 2024 at 11:28 AM Jose Fernandez <jose.fernandez@xxxxxxxxx> wrote:
> >
> > <snip>
> >
> > > > > Lastly, I will never accept new error messages
> > > > > with CONFIG_MODULES=n.
> > > >
> > > > Could you elaborate?
> > > > For me this works fine with CONFIG_MODULES=n.
> > > > (After having fixed the above issues so all subpackages are built)
> > >
> > > $ make allnoconfig pacman-pkg
> > >
> > > Check the linux-headers log closely.
> >
> > I see now, previously I was not on kbuild/for-next and had an old
> > Module.symvers sitting around, hiding the issue.
> >
> > ==> Starting package_linux-upstream-headers()...
> > Installing build files...
> > tar: Module.symvers: Cannot stat: No such file or directory
> > tar: Exiting with failure status due to previous errors
> > Installing System.map and config...
> > Adding symlink...
> > ==> Tidying install...
> >
> > (coming from scripts/package/install-extmod-build)
> >
> > linux-upstream-headers also contains .config and System.map which are
> > useful without modules.
> > So either we completely disable linux-upstream-headers or skip
> > install-extmod-build when CONFIG_MODULES=n.
> > And maybe move System.map and .config to some other package,
> > which would then deviate from the original PKGBUILD.
> >
> > Neither option feels great, but it probably won't make a big difference.
> > If you have a preference, let's go with that.
>
> Thomas, Masahiro,
> Thanks for the feedback. It seems that System.map and .config are commonly
> included in -header Arch packages. To avoid deviating too much and to address
> the issue with install-extmod-build when CONFIG_MODULES=n, how about considering
> something like this:
>
> mkdir -p "${builddir}" # needed if install-extmod-build is not run
> if grep -q CONFIG_MODULES=y include/config/auto.conf; then
> echo "Installing build files..."
> "${srctree}/scripts/package/install-extmod-build" "${builddir}"
> fi
>
> echo "Installing System.map and config..."
> cp System.map "${builddir}/System.map"
> cp .config "${builddir}/.config"
Sounds good to me.
Thomas
