Re: [PATCH v2] kbuild: allow setting zstd compression level for modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 30, 2024 at 11:17 PM Maximilian Bosch <maximilian@xxxxxxxxx> wrote:
>
> From: "torvic9@xxxxxxxxxxx" <torvic9@xxxxxxxxxxx>
>
> Zstd offers a very fine-grained control of compression ratios.
> Add a Kconfig option that allows setting the desired compression
> level for module compression.
>
> Signed-off-by: Tor Vic <torvic9@xxxxxxxxxxx>
> Tested-by: Piotr Gorski <lucjan.lucjanov@xxxxxxxxx>
> Tested-by: Maximilian Bosch <maximilian@xxxxxxxxx>

Missing Signed-off-by?

> +config MODULE_COMPRESS_ZSTD_LEVEL
> +       int "Compression level (1-19)"
> +       depends on MODULE_COMPRESS_ZSTD
> +       range 1 19
> +       default 3

Zstd supports levels up to 22, as well as "negative" ones (`--fast`),
right? I imagine there is a reason for the 1-19 range, but it would be
nice to mention the rationale.

Thanks!

Cheers,
Miguel





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux