On Thu, Jul 18, 2024 at 1:25 AM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Wed, Jul 17, 2024, at 17:18, Masahiro Yamada wrote: > > > > Of course, NACK. > > > > Now I am surprised that this broken series was quickly merged > > into the mainline. > > I really dislike how you changed scripts/Makefile.asm-headers > > > > > > I will send a correct fix. > > Please do not break Kbuild even further. > > Should we maybe revert ff96f5c6971c..3db80c999deb then > and find a better way to do it in 6.12? > > Arnd > > I do not think so. I pretty much like 4fe53bf2ba0a45cd708dcd4c3e8e1950731b3d4d, and I believe generating all syscall headers from a table is the right thing to do. So, it must happen. Currently, the new syscall-y syntax can be used only for architectures using the generic syscall table. I wonder what we should do for the other legacy architectures. Some years ago, I tried to unify 'archheaders' and 'asm-generic' into a more generic rule, but I did not find a nice solution, so I did not do anything. I need to find some way when I have time. For the rebuild problem, I think this should work: https://lore.kernel.org/all/20240717162421.1402773-1-masahiroy@xxxxxxxxxx/T/#u (I only compile-tested arch64 and riscv, but the other architectires should be the same pattern.) -- Best Regards Masahiro Yamada