Hi, On Wed, Jun 19, 2024 at 03:02:35PM +0900, Masahiro Yamada wrote: > I do not see any maintainer for tools/build/, but at least > you can find who is picking up the patches. > > > masahiro@zoe:~/ref/linux(master)$ ./scripts/get_maintainer.pl -f tools/build/ Thanks. I've factored some of this into my addressee list. > OK, you bypassed fixdep for fixdep itself. > > fixdep will not be rebuilt when the command line changes, > but it may not be a big deal. > It is not working that way already. Yeah, that was one rough edge. I didn't manage to smooth that one out, but like you say, it's not really much of a regression. (It *can* work today sometimes for just the right kind of incremental build, because you may have a pre-existing fixdep laying around that will be used if available. But it's not really *correct* still.) > BTW, did you have a chance to test your code > with the -j<N> option? > > > I quickly tested your change, and I observed new > "jobserver unavailable" warnings. > > > masahiro@zoe:~/ref/linux(master)$ make -j24 > mkdir -p /home/masahiro/ref/linux/tools/objtool && make > O=/home/masahiro/ref/linux subdir=tools/objtool --no-print-directory > -C objtool > make[4]: warning: jobserver unavailable: using -j1. Add '+' to parent > make rule. > make[5]: warning: jobserver unavailable: using -j1. Add '+' to parent > make rule. > > > > The first line: > > mkdir -p /home/masahiro/ref/linux/tools/objtool && make > O=/home/masahiro/ref/linux subdir=tools/objtool --no-print-directory > -C objtool > > is an existing noise regardless of your change. > (I do not know if anybody cares about this either) Thanks. I tried to tackle the existing and new noise in my posting here: Subject: [PATCH 0/3] tools build: Incorrect fixdep dependencies https://lore.kernel.org/lkml/20240702003119.3641219-1-briannorris@xxxxxxxxxxxx/ Hopefully that's not horribly off the mark, although I'll admit tools/ is a bit of unfamiliar territory. Brian
